Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addonPostprocessTree for type 'style' #3534

Closed
jschilli opened this issue Mar 14, 2015 · 8 comments
Closed

Add addonPostprocessTree for type 'style' #3534

jschilli opened this issue Mar 14, 2015 · 8 comments

Comments

@jschilli
Copy link
Contributor

Currently addon postprocessors that wish to postprocess style files have to run on type 'all'

when running ember serve and changing only a .js file addons that postproceesTrees for 'all' will run even though no style file changes have occurred.

I will try to look into a PR for this next week.

ref: kimroen/ember-cli-autoprefixer#11

cc: // @kimroen

@rwjblue
Copy link
Member

rwjblue commented Mar 14, 2015

Definitely 👍 on this. We should have "js", "all", and "css" types for postprocessTree.

@jschilli
Copy link
Contributor Author

@rwjblue did you mean "js", "all" and "styles" iso "css"

I'm assuming styles as that is what we call addonTrees for in other places

jschilli pushed a commit to jschilli/ember-cli that referenced this issue Mar 20, 2015
jschilli pushed a commit to jschilli/ember-cli that referenced this issue Mar 20, 2015
@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2015

The preprocessors that have in the registry are "js", "template", and "css", so I believe it should match that.

@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2015

Code for preprocessor helper functions is at: https://github.com/ember-cli/ember-cli/blob/master/lib/preprocessors.js

@jschilli
Copy link
Contributor Author

gotcha, so I'll change it to 'css' but it seems odd that we call this.addonTreesFor('styles'); so from an addon author's perspective i'm dealing with 'styles' sometimes and 'css' in others

@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2015

Yes, totally agreed. We should consolidated (likely on styles).

@stefanpenner
Copy link
Contributor

This is causing merge collisions for me, going to try and investigate.

@stefanpenner
Copy link
Contributor

I believe this is the result of a mis-behaving add-on, and isn't the fault of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants