Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember test in CI mode does not exit on Build failed. 0.2.2 #3712

Closed
ezpuzz opened this issue Mar 31, 2015 · 2 comments
Closed

ember test in CI mode does not exit on Build failed. 0.2.2 #3712

ezpuzz opened this issue Mar 31, 2015 · 2 comments
Labels
bug

Comments

@ezpuzz
Copy link

ezpuzz commented Mar 31, 2015

I think due to the new "display errors in browser on autoreload" functionality, ember test does not immediately exit when there are compilation errors in CI mode.

Workaround for now is to use ember build -e test and then run ember test if that succeeds (but involves recompiling it), but I think in CI mode the ember test command should fail immediately on build errors as it used to.
@stefanpenner
Copy link
Contributor

You raise a good point

@rwjblue
Copy link
Member

rwjblue commented Mar 31, 2015

Agreed.

@rwjblue rwjblue added the bug label Mar 31, 2015
marcioj added a commit to marcioj/ember-cli that referenced this issue Apr 7, 2015
@marcioj
[fixes ember-cli#3712] rethrow errors in build task
918d3ec
stefanpenner added a commit that referenced this issue Apr 7, 2015
@stefanpenner
Merge pull request #3826 from marcioj/issue-3712
cddcabf 
[fixes #3712] rethrow errors in build task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @rwjblue @ezpuzz