-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-*** packages include the tmp
dir.
#4199
Comments
This was fixed in #3539, and has been included in versions since ember-cli@0.2.1. Once these packages update to > 0.2.1 (unless they opt out of the upgrade) they will properly ignore |
I reported that to three packages already. If you want to fix that per-package, you could file appropriate issues yourself. |
That's about 3 GiB in total, btw =). |
Ok. I made a list, informed you. If anyone is willing to file appropriate issues to all 87 packages that I mentioned (minus the 3 that I already informed) they are free to do so. That should be probably done by people who use/care about the listed packages. |
@ChALkeR - Sure, seems somewhat editor specific, but it doesn't bother anyone having extra stuff in the ignore file. Mind making a PR? |
issues opened for repos I could find. |
@stefanpenner Great, thanks! =) |
@ChALkeR cool bot. It would be useful for some of our own checks and feedback tools. Is it OSS? |
@stefanpenner That's not a bot. I just downloaded about 1/3 of the packages from npm with wget (latest versions of relatively recent packages, in fact everything published with npm2, that's pretty much everything from nodejs 0.10.x times and later), then extracted them. I needed that for other reasons (code usage checks). That some packages are very large for some reason caught my eye then, and I checked them with filelight (but you could usa |
@ChALkeR makes sense. I have been meaning to pull down all ember-* packages and do some analysis on them. I was hoping I could piggy back off your work ;) Anyways this was one of the data points I wanted to analysis and provide feedback for, so you beat me to it thanks :) |
@stefanpenner I started with downloading the JSON from https://skimdb.npmjs.com/registry/_design/scratch/_view/byField and parsing it (warning: ~230 MiB). Then I filtered the packages list (by npm version), formed a plain list of the download links, joined them with |
That was a pretty good exercise in getting familiar with some addons. If I typo'd a couple of issue numbers, my apologies. but I submitted PRs in this list where I saw them missing. |
this inspired me to hack together: https://github.com/stefanpenner/all-addons |
An update:
This list is based on one week old data and includes the packages that were missing in the initial list: this should be complete or almost complete, while the first list was partial. Previous list excluded all the Still more than 2 GiB of garbage. |
@ChALkeR thanks for the update, the default addon blueprint contains the correct ignore info. Addons that are offending, should have issues opened themselves. Not sure we can do anything else from this side. |
@stefanpenner I'm not asking you to change anything. That was a status update (featuring a full list), and you reopened the issue =). I reported issues to some of those packages, hopefully someone else will do the same for the rest of them. |
@ChALkeR yup, i appreciate the status report, just justifying my closing the issue. |
Disclaimer: I do not use the package, this was found during automated npm packages downloading.
Migrated from emberjs/ember.js#11316 after IRC disussion.
ember-***
npm packages commonly includetmp
(and.idea
) directories.tmp
directories have sizes from 0 MiB to 621 MiB per package. They include duplicate copies of some scripts, and I suspect that are not actually needed in the distribution. I suspect that these directories grow over time (from release to release).This seems to be a common problem for all
ember-***
packages, hence reporting here.List of packages (may be incomplete) with the
tmp
directory size in bytes:I found
tmp
dir in 87 packages and.idea
dir in 64 packages. There could be more.The text was updated successfully, but these errors were encountered: