Cannot disable hinting in addon when isDevelopingAddon is true

[carlbennettnz]

I have an app which includes an npm linked addon in its package.json. Both the app and the addon have hinting: false in their ember-cli-build.js files, and the addon has isDevelopingAddon: () => true in its index.js. If I ember serve the app, the hinting option is ignored for the addon.

[Turbo87]

@carlbennettnz I'm not sure if this is a scenario that we support. Does it work properly when using ember serve from the addon folder?

[carlbennettnz]

Yes.

• ember serve from addon folder
• ember serve from app folder, with isDevelopingAddon: () => false
• ember serve from app folder, with isDevelopingAddon: () => true

In the final case, everything seems functionally correct, but the JSHint errors are shown.

[rwjblue]

https://github.com/ember-cli/ember-cli/blob/master/lib/models/addon.js#L119-L124 should be updated something like:

Addon.prototype.hintingEnabled = function() {
  var isProduction = process.env.EMBER_ENV === 'production';
  var testsEnabledDefault = process.env.EMBER_CLI_TEST_COMMAND || !isProduction;
  var hintingDisabled = this.options && this.options.hinting === false;

  return testsEnabledDefault && !hintingDisabled;
};

[Turbo87]

@carlbennettnz could you check if the solution proposed by @rwjblue works for you? if it does feel free to open a PR

[rwjblue]

(with tests)