You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was broken when we landed #6546. In #6546 we added code that assumes that resultAnnotation is passed to our Builder.prototype.build method (lib/models/builder.js#L96). This is true when our build is triggered by ember-cli-broccoli-sane-watcher due to changes upstream in ember-cli/broccoli-sane-watcher#8.
The fundamental issue is that when running ember build we do not go through ember-cli-broccoli-sane-watcher at all, and we manually invoke our Builder.prototype.build method in the build task (lib/tasks/build.js#L22) but pass in no options.
We either need to make all builds funnel through ember-cli-broccoli-sane-watcher (which seems somewhat odd when we don't want a watcher) or make our build task emit the correct result annotation.
The text was updated successfully, but these errors were encountered:
Note: This does not affect BROCCOLI_VIZ=1 ember serve, which still works properly (since the .build method is invoked by ember-cli-broccoli-sane-watcher).
rwjblue
changed the title
Fix BROCCOLI_VIZ=1 ember build.BROCCOLI_VIZ=1 ember build is broken
Dec 17, 2016
Fix `BROCCOLI_VIZ=1 ember build`.
Ensure an annotation is passed into `Builder.prototype.build` from the build task (even when not using the watcher).
Fixes#6579.
Currently, when linking against master and running
BROCCOLI_VIZ=1 ember build
the following error is triggered:This was broken when we landed #6546. In #6546 we added code that assumes that
resultAnnotation
is passed to ourBuilder.prototype.build
method (lib/models/builder.js#L96). This is true when our build is triggered byember-cli-broccoli-sane-watcher
due to changes upstream in ember-cli/broccoli-sane-watcher#8.The fundamental issue is that when running
ember build
we do not go throughember-cli-broccoli-sane-watcher
at all, and we manually invoke ourBuilder.prototype.build
method in the build task (lib/tasks/build.js#L22) but pass in no options.We either need to make all builds funnel through ember-cli-broccoli-sane-watcher (which seems somewhat odd when we don't want a watcher) or make our build task emit the correct result annotation.
The text was updated successfully, but these errors were encountered: