Project#blueprintLookupPaths should account for ember-blueprint dependencies.
#6952
Comments
|
In blrpnt I moved thenlookup stuff to a Load path passed in to blueprint. So the caller always decides. That approach should make it easier to addresss this problem |
rwjblue
added a commit
to rwjblue/glimmer-blueprint
that referenced
this issue
Apr 11, 2017
Prior to these changes running `ember init -b @glimmer/blueprint` would always download the `latest` release from `npm`'s registry for `@glimmer/blueprint`. This means that it is impossible to actually control your upgrading process. This change makes this package *both* a stand alone blueprint package *and* an addon. The addon creates a blueprint for `@glimmer/blueprint` so that now `ember init -b @glimmer/blueprint` will use whatever version of `@glimmer/blueprint` that you happen to have installed. This mirrors the way ember-cli upgrades work (where you first update the version of ember-cli in the project, then you run `ember init` with that version). Ultimately, this commit should be able to be revertted once the upstream issue is resolved: ember-cli/ember-cli#6952.
|
Shouldn't have been closed by that @glimmer/blueprint PR. |
|
This issue was closed unintentionally again. From glimmerjs/glimmer.js@8b95d66:
|
|
@rwjblue is this still relevant, or can it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Project.prototype.blueprintLookupPathscurrently accounts for theblueprintPathsof all addons, in addition to the project's own blueprints. Unfortunately, this means it cannot resolve blueprints that are "stand alone blueprints" if they are dependencies of the project.Stand alone blueprints (generally installed via
gitURL's ornpmpackages) use theember-blueprintkeyword (instead ofember-addon) to indicate they are not a full blown addon, but instead are a blueprint, this means they will not be included inProject.prototype.blueprintLookupPathsand thereforeBlueprint.lookupwill not find them even if the blueprint is a direct dependency of the project.The text was updated successfully, but these errors were encountered: