This repository has been archived by the owner on Apr 17, 2020. It is now read-only.
Allow usage of blueprint within a blueprinted project. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to these changes running `ember init -b @glimmer/blueprint` would always download the `latest` release from `npm`'s registry for `@glimmer/blueprint`. This means that it is impossible to actually control your upgrading process. This change makes this package *both* a stand alone blueprint package *and* an addon. The addon creates a blueprint for `@glimmer/blueprint` so that now `ember init -b @glimmer/blueprint` will use whatever version of `@glimmer/blueprint` that you happen to have installed. This mirrors the way ember-cli upgrades work (where you first update the version of ember-cli in the project, then you run `ember init` with that version). Ultimately, this commit should be able to be revertted once the upstream issue is resolved: ember-cli/ember-cli#6952.
|
This is ingenious and useful, sounds good to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes running
ember init -b @glimmer/blueprintwould always download thelatestrelease fromnpm's registry for@glimmer/blueprint. This means that it is impossible to actually control your upgrading process.This change makes this package both a stand alone blueprint package and an addon. The addon creates a blueprint for
@glimmer/blueprintso that nowember init -b @glimmer/blueprintwill use whatever version of@glimmer/blueprintthat you happen to have installed. This mirrors the way ember-cli upgrades work (where you first update the version of ember-cli in the project, then you runember initwith that version).Ultimately, this commit should be able to be revertted once the upstream issue is resolved: ember-cli/ember-cli#6952.