[ENHANCEMENT] Use a flat ESLint config file in the app blueprint
#10451
Conversation
There was a problem hiding this comment.
imo, we should probably include gjs/gts support in here by default, since there is no cost to having config for gjs/gts if folks aren't using it.
There was a problem hiding this comment.
Could you provide a todo list for this? I know the recommended flat config of eslint-plugin-ember already brings in the correct parser, etc.
There was a problem hiding this comment.
I need to use recommended-gjs or recommended-gts when needed it seems?
There was a problem hiding this comment.
and set the parser, per the readme here:
https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs
this'll actually solve a lot of problems folks have had with gjs/gts, because there are bugs when a parser is specified outside of overrides with the non-flat config
bertdeblock
changed the title
app blueprint
| ], | ||
| ], | ||
| }, | ||
| ecmaVersion: 'latest', |
There was a problem hiding this comment.
latest should be the default when using a flat config, so this can go? Not sure, because this one is under parserOptions.
| }, | ||
| ecmaVersion: 'latest', | ||
| requireConfigFile: false, | ||
| sourceType: 'module', |
There was a problem hiding this comment.
module should be the default when using a flat config, so this can go? Not sure, because this one is under parserOptions.
There was a problem hiding this comment.
sourceType is determined by the package.json type field, so I think we still need this since we lie about what type of package our projects are (CJS)
First time constructing a flat config, so I probably missed or misconfigured some things.
Still need to test this across various projects.
TODO:
.eslintignorefilebrowserglobals probably