[ENHANCEMENT] Use a flat ESLint config file in the app blueprint
#10451
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| module.exports = { | ||
| overrides: [ | ||
| { | ||
| files: '*.{cjs,js,mjs,ts}', | ||
| options: { | ||
| singleQuote: true, | ||
| }, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <% if (!typescript) { %>import babelEslintParser from '@babel/eslint-parser'; | ||
| <% } %>import eslint from '@eslint/js'; | ||
| import pluginEmberRecommended from 'eslint-plugin-ember/configs/recommended'; | ||
| import pluginNode from 'eslint-plugin-n'; | ||
| import pluginPrettierRecommended from 'eslint-plugin-prettier/recommended'; | ||
| import pluginQunitRecommended from 'eslint-plugin-qunit/configs/recommended'; | ||
| <% if (typescript) { %>import typescriptEslint from 'typescript-eslint'; | ||
| <% } else { %>import globals from 'globals'; | ||
| <% } %> | ||
| /** @type {import('eslint').Linter.FlatConfig[]} */ | ||
| export default [<% if (!typescript) { %> | ||
| // Babel: | ||
| { | ||
| languageOptions: { | ||
| globals: globals.browser, | ||
| parser: babelEslintParser, | ||
| parserOptions: { | ||
| babelOptions: { | ||
| plugins: [ | ||
| [ | ||
| '@babel/plugin-proposal-decorators', | ||
| { decoratorsBeforeExport: true }, | ||
| ], | ||
| ], | ||
| }, | ||
| ecmaVersion: 'latest', | ||
|
There was a problem hiding this comment.
|
||
| requireConfigFile: false, | ||
| sourceType: 'module', | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. sourceType is determined by the package.json |
||
| }, | ||
| }, | ||
| }, | ||
| <% } %> | ||
| // ESLint: | ||
| eslint.configs.recommended, | ||
|
|
||
| // Ember: | ||
| ...pluginEmberRecommended, | ||
| <% if (typescript) { %> | ||
| // TypeScript: | ||
| ...typescriptEslint.configs.recommended.map((config) => ({ | ||
| ...config, | ||
| files: ['**/*.ts'], | ||
| })), | ||
| <% } %> | ||
| // Node: | ||
| { | ||
| ...pluginNode.configs['flat/recommended-script'], | ||
| files: [ | ||
| 'blueprints/*/index.js', | ||
| 'config/**/*.js', | ||
| 'lib/*/index.js', | ||
| 'server/**/*.js', | ||
| '*.js', | ||
| ], | ||
| }, | ||
| { | ||
| ...pluginNode.configs['flat/recommended-module'], | ||
| files: ['*.mjs'], | ||
| }, | ||
|
|
||
| // Qunit: | ||
| { | ||
| ...pluginQunitRecommended, | ||
| files: ['tests/**/*-test.{js,ts}'], | ||
| }, | ||
|
|
||
| // Prettier: | ||
| pluginPrettierRecommended, | ||
| ]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, we should probably include gjs/gts support in here by default, since there is no cost to having config for gjs/gts if folks aren't using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a todo list for this? I know the recommended flat config of eslint-plugin-ember already brings in the correct parser, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to use
recommended-gjsorrecommended-gtswhen needed it seems?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and set the parser, per the readme here:
https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs
this'll actually solve a lot of problems folks have had with gjs/gts, because there are bugs when a parser is specified outside of overrides with the non-flat config