Add addon.postBuild hook #1215
Merged
Add addon.postBuild hook #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecraige
changed the title
| build: function() { | ||
| return this.builder.build.apply(this.builder, arguments) | ||
| .then(this.processBuildResult.bind(this)); | ||
| .then(this.processBuildResult.bind(this)).then(this.addonsPostBuild.bind(this)); |
There was a problem hiding this comment.
Can you move this down to the next line?
…rary code after each build
|
@rjackson fixed and rebased. should pass this time around, lol |
|
@rjackson looks like we need a rerun, just one failed |
|
LGTM @stefanpenner - +1/-1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement a postBuild hook in the builder addons can use to run arbitrarary code after each build
This allows an added to hook into the build/rebuild process and return a promise that will be passed the results from the processBuildResult method.
My use case for this is that after every rebuild, I need to run
cordova build ioson the command line but it does not affect the output of the js/css files so it needs to be after everything is done