Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model generation without attribute type #1252

Closed
wants to merge 2 commits into from
Closed

Model generation without attribute type #1252

wants to merge 2 commits into from

Conversation

kellyselden
Copy link
Member

ember g model user username password

would yield

export default DS.Model.extend({
  username: DS.attr(),
  password: DS.attr()
});

"If you don't specify the type of the attribute, it will be whatever was provided by the server"
http://emberjs.com/guides/models/defining-models/

@stefanpenner
Copy link
Contributor

LGTM

@jgwhite c/d

@jgwhite
Copy link
Contributor

jgwhite commented Jul 3, 2014

c 100%

@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2014

Random Travis failure, restarting build...

rwjblue
rwjblue reviewed Jul 3, 2014
View reviewed changes
CHANGELOG.md
@@ -20,6 +20,7 @@
* [ENHANCEMENT] Allow testing of production assets. [#1230](https://github.com/stefanpenner/ember-cli/pull/1230)
* [ENHANCEMENT] Provide Ember CLI version to Project model. [#1239](https://github.com/stefanpenner/ember-cli/pull/1239)
* [BREAKING ENHANCEMENT] Split `app/templates` into its own tree to prevent preprocessing template files as if they were JavaScript. [#1238](https://github.com/stefanpenner/ember-cli/pull/1238)
* [ENHANCEMENT] Model generation no longer requires an attribute type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the PR number as a link here?

@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2014

Can you squash your commits, and rebase against current master?

@stefanpenner
Copy link
Contributor

rebasing + merging manually

@rwjblue
Copy link
Member

rwjblue commented Jul 4, 2014

@stefanpenner - ❤️

@kellyselden
Copy link
Member Author

@stefanpenner Thanks. Next time I will fix my commits.

@kellyselden kellyselden deleted the model-generator-change branch July 4, 2014 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kellyselden @stefanpenner @jgwhite @rwjblue