I don’t think we need this anymore. #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
remove-old-dep
branch
2 times, most recently
from
249b1ab
to
be6f26b
Compare
stefanpenner
force-pushed
the
remove-old-dep
branch
from
be6f26b
to
c6b6527
Compare
|
I think its fine to remove, as long as we have a |
stefanpenner
added a commit
that referenced
this pull request
Jan 5, 2015
I don’t think we need this anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe we do..3a439e1#diff-f1e1923c0440a385f51d2a81c0e53b64R63
But I would like to get a path forward, were we don't need this.
If this is merely going to be a breaking change for add-ons then we will doit, and bump the version accordingly.
Also if this is something we want to support, we need proper test coverage.