findAddonByName returning incorrect matches #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecraige
changed the title
jakecraige
changed the title
|
Lgtm. @rwjblue r? |
rwjblue
added a commit
that referenced
this pull request
Jan 8, 2015
findAddonByName returning incorrect matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #2915
I'm trying to figure out how best to handle this. I did
indexOfinstead of===because of this case tested hereI think this method is decent. The only concern I'd have is for perf since it iterates over
this.addonstwice(potentially), but I can't imagine that costing too much overall. If any of you have concerns or a better solution I'll happily implement it