Hide passed tests by default.

blueprints/app/files/testem.json

@@ -1,6 +1,6 @@
 {
   "framework": "qunit",
-  "test_page": "tests/index.html",
+  "test_page": "tests/index.html?hidepassed",
   "launch_in_ci": [
     "PhantomJS"
   ],

lib/commands/test.js

@@ -51,7 +51,10 @@ module.exports = Command.extend({
     var customPath = path.join(tmpPath, 'testem.json');
     var originalContents = JSON.parse(fs.readFileSync(options.configFile, { encoding: 'utf8' }));
 
-    originalContents['test_page'] = originalContents['test_page'] + this.buildTestPageQueryString(options);
+    var containsQueryString = originalContents['test_page'].indexOf('?') > -1;
+    var testPageJoinChar    = containsQueryString ? '&' : '?';
+
+    originalContents['test_page'] = originalContents['test_page'] + testPageJoinChar + this.buildTestPageQueryString(options);
     fs.writeFileSync(customPath, JSON.stringify(originalContents));
 
     return customPath;
@@ -68,7 +71,7 @@ module.exports = Command.extend({
       params.push('filter=' + options.filter);
     }
 
-    return params.length ? '?' + params.join('&') : '';
+    return params.join('&');
   },
 
   run: function(commandOptions) {

tests/fixtures/tasks/testem-config/testem-with-query-string.json

@@ -0,0 +1,11 @@
+{
+  "framework": "qunit",
+  "test_page": "tests/index.html?hidepassed",
+  "launch_in_ci": [
+    "PhantomJS"
+  ],
+  "launch_in_dev": [
+    "PhantomJS",
+    "Chrome"
+  ]
+}

tests/unit/commands/test-test.js

@@ -105,7 +105,7 @@ describe('test command', function() {
     var fixturePath;
 
     beforeEach(function() {
-      fixturePath = path.join(__dirname, '..', '..', 'fixtures', 'tasks', 'default-testem-config');
+      fixturePath = path.join(__dirname, '..', '..', 'fixtures', 'tasks', 'testem-config');
       command = new TestCommand(options);
       runOptions = {
         configFile: path.join(fixturePath, 'testem.json')
@@ -163,39 +163,47 @@ describe('test command', function() {
       var newPath = command._generateCustomConfigFile(runOptions);
       var contents = JSON.parse(fs.readFileSync(newPath, { encoding: 'utf8' }));
 
-      expect(contents['test_page'].indexOf('fooModule') > -1);
-      expect(contents['test_page'].indexOf('bar') > -1);
+      expect(contents['test_page']).to.be.equal('tests/index.html?module=fooModule&filter=bar');
     });
 
     it('when module and filter option is present uses buildTestPageQueryString for test_page queryString', function() {
       runOptions.filter = 'bar';
       command.buildTestPageQueryString = function(options) {
         expect(options).to.deep.equal(runOptions);
 
-        return '?blah=zorz';
+        return 'blah=zorz';
       };
 
       var newPath = command._generateCustomConfigFile(runOptions);
 
       var contents = JSON.parse(fs.readFileSync(newPath, { encoding: 'utf8' }));
 
-      expect(contents['test_page'].indexOf('?blah=zorz') > -1);
+      expect(contents['test_page']).to.be.equal('tests/index.html?blah=zorz');
     });
 
     it('new file returned contains the filter option value in test_page', function() {
       runOptions.filter = 'foo';
       var newPath = command._generateCustomConfigFile(runOptions);
       var contents = JSON.parse(fs.readFileSync(newPath, { encoding: 'utf8' }));
 
-      expect(contents['test_page'].indexOf('foo') > -1);
+      expect(contents['test_page']).to.be.equal('tests/index.html?filter=foo');
+    });
+
+    it('adds with a `&` if query string contains `?` already', function() {
+      runOptions.filter = 'foo';
+      runOptions.configFile = path.join(fixturePath, 'testem-with-query-string.json');
+      var newPath = command._generateCustomConfigFile(runOptions);
+      var contents = JSON.parse(fs.readFileSync(newPath, { encoding: 'utf8' }));
+
+      expect(contents['test_page']).to.be.equal('tests/index.html?hidepassed&filter=foo');
     });
 
     it('new file returned contains the module option value in test_page', function() {
       runOptions.module = 'fooModule';
       var newPath = command._generateCustomConfigFile(runOptions);
       var contents = JSON.parse(fs.readFileSync(newPath, { encoding: 'utf8' }));
 
-      expect(contents['test_page'].indexOf('fooModule') > -1);
+      expect(contents['test_page']).to.be.equal('tests/index.html?module=fooModule');
     });
   });
 });