Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide passed tests by default. #3068

Merged
merged 2 commits into from Jan 23, 2015
Merged

Hide passed tests by default. #3068

merged 2 commits into from Jan 23, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 22, 2015

  • Add ?hidepassed to testem.json by default (which tells QUnit to hide passed tests).
  • Fix an issue with using a testem.json test_page value that already contains a question mark along with the --filter option.
  • Update tests to make assertions on the full test_page instead of just doing indexOf checks.

@rwjblue
Allow default test_page to contain a query string.
ad86fa1 
Prior to this commit running `ember test --filter="foo"` with a
`test_page` of `tests/index.html?hidepassed` would have resulted in
`tests/index.html?hidepassed?filter=foo`.
@rwjblue
Hide passed tests by default.
0a03365
@rwjblue
Copy link
Member Author

rwjblue commented Jan 23, 2015

@stefanpenner - r?

stefanpenner added a commit that referenced this pull request Jan 23, 2015
@stefanpenner
Merge pull request #3068 from rwjblue/do-not-add-two-query-strings
16e0581 
Hide passed tests by default.
@stefanpenner stefanpenner merged commit 16e0581 into ember-cli:master Jan 23, 2015
@rwjblue rwjblue deleted the do-not-add-two-query-strings branch January 2, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwjblue @stefanpenner @jakecraige