Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update ember-qunit to 0.2.0. #3170

Merged
merged 2 commits into from
Feb 2, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 1, 2015

The update to ember-qunit 0.2.0 has a few caveats but is largely compatible with 0.1.x. A few of the main changes are:

  • Rewritten to be a thin wrapper around ember-test-helpers, which are now shared between ember-qunit and ember-mocha.
  • Deprecated this.append() in favor of this.render() in moduleForComponent.
  • setup callback no longer receives the container as its first argument. This requires a largely mechanical refactor to use this.container in the callback (instead of using the first argument).

Users that update ember-cli-qunit, but not ember-qunit will see no changes (ember-cli-qunit itself is compatible with both versions).

This parameter was mandatory in ember-qunit 0.1.8, but is now optional
as of 0.2.0.
@chadhietala
Copy link
Member

👍

abuiles added a commit that referenced this pull request Feb 2, 2015
[ENHANCEMENT] Update ember-qunit to 0.2.0.
@abuiles abuiles merged commit db0064c into ember-cli:master Feb 2, 2015
@abuiles
Copy link
Member

abuiles commented Feb 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants