Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default to development asset #3216

Merged
merged 3 commits into from Feb 24, 2015
Merged

Do not default to development asset #3216

merged 3 commits into from Feb 24, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2015

I removed default to development asset, this is not consistent with app.import(null).
See #3215

@stefanpenner
Copy link
Contributor

this should like to and in check instead

@stefanpenner stefanpenner self-assigned this Feb 24, 2015
@ghost ghost closed this Feb 24, 2015
@ghost ghost reopened this Feb 24, 2015
@ghost
Copy link
Author

ghost commented Feb 24, 2015

Added an update, which use in to check if current env is set.

(5 blueprint related tests fail, these also fail if I roll back to before my patches.)

rwjblue added a commit that referenced this pull request Feb 24, 2015
Do not default to development asset
@rwjblue rwjblue merged commit e159286 into ember-cli:master Feb 24, 2015
@rwjblue
Copy link
Member

rwjblue commented Feb 24, 2015

@martndemus - Thank you!

@ghost
Copy link
Author

ghost commented Feb 24, 2015

@rwjblue NP, this is way better than having to use an empty file.

@ghost ghost deleted the fix-null-env-import branch February 24, 2015 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants