Moved reverse() to after filter() so we can keep consistent order

[nathanpalmer]

I have a project that has multiple "overrides" for blueprints. However the paths for the main blueprint and the test blueprint were coming up in an inconsistent order. That means I would get the main blueprint for one project and the test blueprint for another.

To help illustrate the problem I have this

1. ember-cli
2. ember-coffeescript
3. in-repo addon

When I run this command

ember g adapter users --dry-run

It chooses the adapter blueprint from in-repo addon and the adapter-test blueprint from ember-coffeescript. Even-though both blueprints exist in the in-repo addon. When I traced it down it seemed to work everytime as long as we reverse after the filter.

[trabus]

Do you think it would be much work to add a test for this? Would probably be a good thing to check for regression.

[stefanpenner]

@trabus is correct, this detail must be tested.

[nathanpalmer]

@trabus @stefanpenner I added a test that shows that it fails when we call this method twice. This is what happens when we get the lookupPaths for the main blueprint and then a second time for the test blueprint

[stefanpenner]

@nathanpalmer any luck on getting the tests passing though?

[nathanpalmer]

@stefanpenner The test I added and the test I modified are passing just fine.

The master build however wasn't passing when I forked. It seems only related to the iojs build starting with this commit and this build.

[trabus]

It's actually been failing since this was merged.

As far as the tests go, lgtm 👍

[trabus]

If you rebase after #3250 gets merged in, we can be sure.

[rwjblue]

#3250 is merged, can you rebase?

[nathanpalmer]

Sure, I'll rebase when I get home.

[rwjblue]

Thanks!