Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Update ember-cli-qunit to v0.3.8. #3298

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 15, 2015

Previously, if a given test failed to load we would console.error the failure, which may or may not help folks find them.

This update makes those module load failures actual fail a test, so that you get decent warning/info that a whole module of your tests cannot be run.

screenshot

Closes #3201.

@rwjblue rwjblue mentioned this pull request Feb 15, 2015
4 tasks
Previously, if a given test failed to load we would `console.error` the failure, which may or may not help folks find them.

This update makes those module load failures actual fail a test, so that you get decent warning/info that a whole module of your tests cannot be run.

![screenshot](http://monosnap.com/image/WJ5CyNsBszjrWSie9Y9TtOj07x8LS3.png)
@rwjblue rwjblue force-pushed the fail-build-when-test-modules-arent-parsable branch from ae20594 to 3ce94f4 Compare February 15, 2015 18:40
rwjblue added a commit that referenced this pull request Feb 15, 2015
…ent-parsable

[BUGFIX] Update ember-cli-qunit to v0.3.8.
@rwjblue rwjblue merged commit 3e9883e into ember-cli:master Feb 15, 2015
@rwjblue rwjblue deleted the fail-build-when-test-modules-arent-parsable branch February 15, 2015 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing issues
2 participants