Nested addons should be overrideable from parent. #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial logic added to call `treeFor` on all of a given addons nested children had the following issues: * The trees returned could not be overridden by the including addon. * The final merging of those trees did not use the `overwrite: true` flag, which meant that any shared addons would throw an error instead of simply using the last one (which is the Ember CLI 0.1.x behavior).
|
Should address an issue pointed out in IRC by @lukemelia. |
rwjblue
added a commit
that referenced
this pull request
Feb 22, 2015
Nested addons should be overrideable from parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial logic added to call
treeForon all of a given addonsnested children had the following issues:
overwrite: trueflag, which meant that any shared addons would throw an error instead
of simply using the last one (which is the Ember CLI 0.1.x behavior).