Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes match application regex #3412

Merged
merged 1 commit into from Apr 2, 2015
Merged

Changes match application regex #3412

merged 1 commit into from Apr 2, 2015

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Mar 3, 2015

Changes match regex for application tree to "startsWith".
(fixes the case when jQuery files were matched when project's name is query).

Fixes #3403.

@twokul
Copy link
Contributor Author

twokul commented Mar 3, 2015

cc @chadhietala

@chadhietala
Copy link
Member

Restarting CI.

@rwjblue
Copy link
Member

rwjblue commented Mar 4, 2015

test please

@stefanpenner
Copy link
Contributor

cc @twokul, you may have forgotten about this one.

@stefanpenner
Copy link
Contributor

@twokul friendly reminder

@twokul
Copy link
Contributor Author

twokul commented Mar 26, 2015

@stefanpenner do you mind helping me out with the test? I'm not 100% I wrote it correctly.

@twokul
Copy link
Contributor Author

twokul commented Apr 1, 2015

@chadhietala @rwjblue fellas, mind restarting appveyor?

@chadhietala
Copy link
Member

Appveyor restarted.

@twokul
Copy link
Contributor Author

twokul commented Apr 1, 2015

@chadhietala 👍

stefanpenner added a commit that referenced this pull request Apr 2, 2015
Changes match application regex
@stefanpenner stefanpenner merged commit ae97905 into ember-cli:master Apr 2, 2015
@twokul twokul deleted the query-name branch April 3, 2015 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ember-cli project failing because project name is 'query'
5 participants