disable visual progress effect in dumb terminals #3463
Conversation
| @@ -66,7 +66,7 @@ function cli(options) { | |||
| var ui = new UI({ | |||
| inputStream: options.inputStream, | |||
| outputStream: options.outputStream, | |||
| ci: process.env.CI, | |||
| ci: process.env.CI || /^(dumb|emacs)$/.test(process.env.TERM), | |||
There was a problem hiding this comment.
Should we use process.stdout.isTTY instead of process.env.TERM?
https://nodejs.org/api/process.html#process_process_stdout
https://nodejs.org/api/tty.html#tty_tty
There was a problem hiding this comment.
It looks like process.stdout.isTTY has more to do with the process pipe type than with the terminal's capabilities, because it behaves differently across platforms. On Windows process.stdout.isTTY is true inside the Windows console and false inside emacs eshell and compilation-mode like we might expect for it to work here, but on OSX it is true inside all of them: emacs eshell, compilation-mode, as well as a real terminal.
There was a problem hiding this comment.
sounds like TERM might be the more resilient solution
@rwjblue thoughts?
There was a problem hiding this comment.
Happy to give it a go as process.env.TERM...
|
#yolo |
disable visual progress effect in dumb terminals
Disables visual progress indicators in dumb terminals such as editor buffers which don't support terminal cursor movement. They configure the environment with
TERM=dumband in the case of emacs it configures the environment withTERM=emacsin compilation mode.