[BUGFIX] Fixes nested component generation in addons with correct relative path for template import #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trabus
force-pushed
the
addon-component-relative-paths
branch
2 times, most recently
from
da950ad
to
a0cb797
Compare
|
You need to rebase, it will update AppVeyor to use Node 0.12. |
trabus
force-pushed
the
addon-component-relative-paths
branch
2 times, most recently
from
dbef569
to
87671f5
Compare
…correct relative path for template import
trabus
force-pushed
the
addon-component-relative-paths
branch
from
87671f5
to
a46602d
Compare
|
@rwjblue Appveyor feels like a slot machine sometimes. Finally got it to run without timing out on a random test. |
trabus
changed the title
|
👍 |
stefanpenner
added a commit
that referenced
this pull request
Mar 14, 2015
[BUGFIX] Fixes nested component generation in addons with correct relative path for template import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3514
Generating nested components inside of an addon was not taking into account the path depth when generating the template import path.