[BUGFIX] Add missing bind when server already in use #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Fixes #3519 |
|
ugh, thank you! Why didn't our tests catch this? |
|
I thought https://github.com/ember-cli/ember-cli/blob/master/tests/unit/tasks/server/express-server-test.js#L122-L139 was testing this directly... |
|
I just stumbled on this on as well. |
Using `done` was causing the tests to pass erroneously. Worryingly `expect(false...` will not cause the test to fail.
stefanpenner
added a commit
that referenced
this pull request
Mar 13, 2015
[BUGFIX] Add missing bind when server already in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 43a8a6d