[BUGFIX] Replace marked with markdown-it #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanpenner @rwjblue ready for review! |
rwjblue
added a commit
that referenced
this pull request
Mar 14, 2015
[BUGFIX] Replace marked with markdown-it
|
Nice! |
|
❤️ @trabus |
|
rad! |
|
It had a nice side effect of forcing me to publish my first npm package ever. Never had any reason to do so before. |
|
@trabus - NICE! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3455 by removing
markedandmarked-terminalas dependencies and replaces them withmarkdown-itandmarkdown-it-terminal.This PR focuses on getting the vulnerable dependency out of ember-cli. I will be following up later and will eventually remove the color parsing from ember-cli and move it into markdown-it-terminal.