Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Ensure package.json main entry point is used for addon lookup. #3545

Merged
merged 3 commits into from
Mar 17, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 15, 2015

No description provided.

@stefanpenner
Copy link
Contributor

  1) models/addon.js resolvePath allows lookup of non-`index.js` `main` entry points:
     TypeError: Cannot read property 'main' of undefined
      at Function.Addon.resolvePath (/home/travis/build/ember-cli/ember-cli/lib/models/addon.js:642:72)
      at Context.<anonymous> (/home/travis/build/ember-cli/ember-cli/tests/unit/models/addon-test.js:146:46)
      at callFn (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runnable.js:250:21)
      at Test.Runnable.run (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runnable.js:243:7)
      at Runner.runTest (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:373:10)
      at /home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:451:12
      at next (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:298:14)
      at /home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:308:7
      at next (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:246:23)
      at Object._onImmediate (/home/travis/build/ember-cli/ember-cli/node_modules/mocha/lib/runner.js:275:5)

@rwjblue rwjblue force-pushed the allow-main-entry-point-to-work branch from f9934c5 to 6732c12 Compare March 16, 2015 02:25
@rwjblue
Copy link
Member Author

rwjblue commented Mar 16, 2015

Updated to fix that error, but am now seeing acceptance test failures indicating that broccoli-asset-rev didn't run properly. Will dig into it in a bit...

@rwjblue
Copy link
Member Author

rwjblue commented Mar 16, 2015

Pull request fixing the issue in broccoli-asset-rev: ember-cli/broccoli-asset-rev#37

@stefanpenner
Copy link
Contributor

broccol-asset-rev pr has been merged.

@rwjblue
Copy link
Member Author

rwjblue commented Mar 16, 2015

Bumped version of broccoli-asset-rev to include fixes.

rwjblue added a commit that referenced this pull request Mar 17, 2015
[BUGFIX] Ensure `package.json` `main` entry point is used for addon lookup.
@rwjblue rwjblue merged commit e38e6d8 into ember-cli:master Mar 17, 2015
@rwjblue rwjblue deleted the allow-main-entry-point-to-work branch March 17, 2015 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants