Added babel to addons package.json dependencies by default #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with this, but leaving ember-cli-babel in both deps and devDeps generally triggers a warning by NPM. I think that if we remove it from devDeps, the dummy app will still work as expected, can you confirm (then fix)? |
… es6++, but addon/app trees do too. Fixes ember-cli#3556
|
@rwjblue confirmed. Dummy still gets babel when in deps-only. Made the change. 👍 |
|
Thanks @jayphelps |
rwjblue
added a commit
that referenced
this pull request
Mar 18, 2015
Added babel to addons package.json dependencies by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussions over at #3556, I don't see any real harm in giving this to addons by default since they don't have to use babel syntax and if they truly care, they can simply remove it from them package.json, just like many do for content-security-policy, among others. Good defaults--that's the "ember way"
I think creating options/flags is overcomplicating things. At least as a first pass. If someone wants to add a flag to exclude it, that's cool sugar.
*I would love to write a test for this, but would require some decent refactoring and/or using mock-fs or something. The current addon package.json isn't being tested, I vote get this out then I have cycles to pair with Robert or Stef to refactor so we can test these sort of things, if they'd like.