[BREAKING ENHANCEMENT] Update ember-cli-content-security-policy to v0.4.0 #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sir-dunxalot
changed the title
|
Not sure why the Travis build failed - the failing test seems somewhat unrelated to my one line change. Everything is passing on my local so is there something else I should be aware of? |
|
How is this a breaking change? The diff indicates that the changes were only additive.... |
|
From CONTRIBUTING.md:
Did I misread that? |
|
HA! Nope, you got it right. I think everyone else needs to read the guide though.. 😉 Thank you! |
rwjblue
added a commit
that referenced
this pull request
Mar 20, 2015
[BREAKING ENHANCEMENT] Update ember-cli-content-security-policy to v0.4.0
|
Honestly I nearly missed it too haha. Thanks for the quick turn around (and all your work with Ember CLI!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of ember-cli-content-security-policy that vanilla Ember apps are generated with.
The benefit of this is to avoid rwjblue/ember-cli-content-security-policy#27, which was creating unnecessary console errors for Ember users.