Teaches updateChecker about dev builds #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +81,7 @@ describe('Update Checker', function() { | |||
|
|
|||
| return function() { | |||
| updateChecker.versionConfig = versionConfig; | |||
| debugger | |||
|
Awesome |
| @@ -56,8 +56,16 @@ UpdateChecker.prototype.doCheck = function() { | |||
| }.bind(this)).catch(function() { | |||
| return this.checkNPM(); | |||
| }.bind(this)).then(function(version) { | |||
| // match postfix SHA in dev version | |||
| var isDevBuild = !!this.localVersion.match(/\b[0-9a-f]{5,40}\b/); | |||
There was a problem hiding this comment.
I think I'd rather make lib/utilities/ember-cli-version.js be the only thing that has to be aware of this. Can we make that script export another function (like isDevelopment()) then just consume it here?
I'm mostly concerned with having the concept of what exactly goes into a dev build version number be encapsulated in a single place.
There was a problem hiding this comment.
@rwjblue makes sense to me. I'll make a change on the flught
|
@stefanpenner @rwjblue I think this is ready for another look |
rwjblue
added a commit
that referenced
this pull request
Mar 22, 2015
Teaches updateChecker about dev builds
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3494