Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add in-repo-addon generate and destroy support #3585

Merged
merged 1 commit into from Mar 25, 2015

Conversation

trabus
Copy link
Contributor

@trabus trabus commented Mar 21, 2015

This PR adds the ability to generate and destroy blueprints inside of in-repo-addons by adding a --in-repo-addon flag to the generate and destroy commands. It also adds support for components as the first blueprint to be able to generate inside an in-repo-addon.

ember generate component foo-bar --in-repo-addon my-addon
or using shorthand:
ember g component foo-bar -in-repo my-addon

This needs some follow up with docs, it would be helpful to know that you can generate blueprints inside in-repo-addons.

@stefanpenner
Copy link
Contributor

LGTM, my only comment is: it makes me slightly un-easy to add many if statements to add this sort of functionality. It would be great if a later refactoring utilized polymorphism instead.

@rwjblue r?

@trabus
Copy link
Contributor Author

trabus commented Mar 21, 2015

@stefanpenner
Copy link
Contributor

@stefanpenner This is what structures would provide

👍

@trabus trabus force-pushed the generate-in-repo-addon branch 5 times, most recently from e4e784e to 8c7c436 Compare March 24, 2015 14:06
@stefanpenner
Copy link
Contributor

kicking appveyor.

@stefanpenner stefanpenner added this to the v0.2.2 milestone Mar 24, 2015
stefanpenner added a commit that referenced this pull request Mar 25, 2015
[ENHANCEMENT] Add in-repo-addon generate and destroy support
@stefanpenner stefanpenner merged commit 19965fa into ember-cli:master Mar 25, 2015
@noslouch
Copy link

I think this caused a regression to #2329. I'm seeing vim swap and undo history files get swept up in the build process after generating a component using ember generate component foo-bar --in-repo-addon addon-name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants