Add remove packages #3842
Add remove packages #3842
Conversation
…file to solve the vars-on-top ESLint error.
|
@rwjblue I'm pretty sure those timeouts mentioned in the appveyor ci are not relevant. What do you think to the API anyway? |
| @@ -894,6 +894,60 @@ Blueprint.prototype.addPackagesToProject = function(packages) { | |||
| }; | |||
|
|
|||
| /** | |||
| Used to remove a package from the projects `package.json`. | |||
|
|
|||
| Generally, this would be done from the `afterInstall` hook, to | |||
There was a problem hiding this comment.
It looks like this description is a copy-past of the addPackage? Could you fix that please.
|
@jonathanKingston thanks! can you please address some of the comments? |
|
@abuiles working on these now sorry for missing those. |
jonathanKingston
force-pushed
the
add-remove-packages
branch
2 times, most recently
from
58df95b
to
331adc2
Compare
|
@abuiles do these smoke tests cause issues on other pulls? I added in another test for the singular case to pass the new coveralls. |
|
@jonathanKingston Yes, the AppVeyor build currently has issues. |
|
@kellyselden +1 thanks for the quick response. |
| /** | ||
| Used to remove multiple packages from the projects `package.json`. | ||
|
|
||
| Generally, this would be done from the `afterInstall` hook, to |
There was a problem hiding this comment.
Can you please fix the description, the following: ensure that a package that is required by a given blueprint is is not really what this is for, right?
There was a problem hiding this comment.
@abuiles yup updated sorry for the back and forwards with this, it's not acceptable I am sorry for that.
jonathanKingston
force-pushed
the
add-remove-packages
branch
from
331adc2
to
a0911ff
Compare
|
Thanks! |
|
Thanks for your help with this 👍 |
Issue: #3841