Disable directory listings on development server #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!fs.existsSync(path.join(results.directory, assetPath))) { | ||
| var isFile = false; | ||
| try { isFile = fs.statSync(path.join(results.directory, assetPath)).isFile(); } catch (err) { } | ||
| if (!isFile) { |
There was a problem hiding this comment.
Broccoli's middleware just calls next() instead of serving 404. So if possible, it might be nicer to rearrange the middleware stack so this check becomes unnecessary. I just didn't want to try doing this right now.
There was a problem hiding this comment.
If you need Broccoli to call next() on non-GET (or some other requests like that) to make that possible, I'm happy to merge a PR.
|
👍 |
|
@joliss I just tried this and it works great, thanks! |
abuiles
added a commit
that referenced
this pull request
Apr 17, 2015
Disable directory listings on development server
|
@joliss thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwjblue, you mentioned that you want this...
My only worry would be that anybody trying to have an
/assetsroute in their Ember app might have a bad surprise when they deploy to production, depending on how their server or CDN is set up, and now thatautoIndexis false we're not catching that in development anymore. But I'm unsure.