Export test output dir via ENV #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives you a way for custom testem launchers to discover where the
built output is. For example, if your build contains tests that node can
run you can put a launcher like this into testem.json:
```js
"launchers": {
"NodeTests": {
"command": "mocha -R tap $EMBER_CLI_TEST_OUTPUT/node_modules/tests",
"protocol": "tap"
}
```
|
👍 |
|
thoughts on |
|
Output path is already configurable, this exposes the specified output path to yhe custom testem runners. |
i get it now... /me hides |
|
does this form of environment variable work in windows? |
|
Yes, setting an environment variable like this does work on windows. The custom testem.json launcher config may be slightly different than in the description above, but that should be fine for us here (since we aren't actually adding that by default). |
|
the npm/node_modules cache was stale |
stefanpenner
added a commit
that referenced
this pull request
Apr 28, 2015
Export test output dir via ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom testem launchers to discover the location of the build output. Browser-based launchers don't need this because they all point at the server URL, but process-based launchers have no other way of finding the build.
For example, I have a project that outputs some node-formatted tests alongside the usual browser-formatted stuff. With this PR I can add a node-based launcher to testem.json: