Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included modules is no longer needed #3975

Merged
merged 1 commit into from
May 6, 2015
Merged

Conversation

stefanpenner
Copy link
Contributor

  • pre-packager will require an explicit dep-graph.json
  • we no longer need module information for the module transpiler
  • glob is basically broken in windows on shares – pending: Unc path isaacs/node-glob#192
  • this is clearly changes untested behavior, I suspect this iteration is ultimately invalid because now all add-ons are compiled. I would like to explore a better solution anyways.

cc @rwjblue / @chadhietala this is robs original work, but overlaps with some of the pre-packager future. so both your input would be great

* pre-packager will require an explicit dep-graph.json
* we no longer need module information for the module transpiler
* glob is basically broken in windows on shares – pending: isaacs/node-glob#192
@chadhietala
Copy link
Member

LGTM.

rwjblue added a commit that referenced this pull request May 6, 2015
@rwjblue rwjblue merged commit 33f6674 into master May 6, 2015
@twokul twokul removed the in progress label May 6, 2015
@rwjblue rwjblue deleted the remove-included-modules branch May 6, 2015 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants