Changed markdown-color blue to bright-blue to be the same on all platforms #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
added a commit
that referenced
this pull request
Apr 30, 2015
Changed markdown-color blue to bright-blue to be the same on all platforms
|
this should not have been merged, mucking with a dependencies values isn't a reasonable approach. This contamination is why we are in this situation in the first place. |
|
Heh, yet that is what chalk is doing that is causing us grief. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chalk changes blue to bright blue when on windows, causing the utilities/markdown-color unit tests to fail on windows.
This PR sets chalk's blue to bright blue for all platforms, fixing the tests for the time being until it can be fixed upstream.