Update helper blueprint to use Ember.Helper.helper
#4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good (and yes master |
This is line with the new Helper API as described on http://emberjs.com/blog/2015/06/12/ember-1-13-0-released.html#toc_new-ember-js-helper-api
|
I fixed the tests (I think) but the Appveyor build still fails for something that to me seems unrelated to the code changes. I also tried to force a rebuild by pushing an empty commit but that did not help. Does that happen a lot? |
|
the windows failure has been happening for the last few days, it looks like am environment issue, but may also be related to #4348 cc @chadhietala |
rwjblue
added a commit
that referenced
this pull request
Jul 6, 2015
Update helper blueprint to use `Ember.Helper.helper`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is line with the new Helper API as described on
http://emberjs.com/blog/2015/06/12/ember-1-13-0-released.html#toc_new-ember-js-helper-api .
I assume here that the next version of Ember CLI will install Ember 1.13.x by default. If this is not the case, merging this PR should probably be postponed.