Add a test-page option to the test command #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows arbitrary query parameters to be passed for something like ember-cli-blankets ?coverage option.
|
@jrjohnson nice. Bikeshedding some here, but |
|
I didn't want to stray to far from the testem.json value which is test_page, but other than that I have no attachment to it. Want me to switch it up? |
|
👍 |
stefanpenner
added a commit
that referenced
this pull request
Jul 5, 2015
Add a test-page option to the test command
This was referenced Jul 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the less controversial path for fixing #4365. This adds a --test-page option to the test command which allows arbitrary query parameters to be passed for something like ember-cli-blankets ?coverage option.
eg
The (admittedly biased) discussion in #4365 was in favor of adding a --coverage option. I'm worried that adding the option would imply coverage would run for new users even without an addon. On the other hand its a lot clearer what to do with --coverage as opposed to --test-page. Its a pretty simple change either way so all feedback welcome.