[BUGFIX] Fixes #4397 add silentError with deprecation #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var silentError = require('silent-error'); | ||
| var deprecate = require('../utilities/deprecate'); | ||
|
|
||
| module.exports = function(){ |
There was a problem hiding this comment.
this would need to be
Object.defineProperty(module, 'exports', {
get: function () { return SilentError; }
});
or the consumer must do:
require('silent-error')(); // <-- notice the extra ();There was a problem hiding this comment.
although a pain, we should add a test to confirm.
|
|
||
| describe('SilentError', function() { | ||
| it('return silent-error and print a deprecation', function() { | ||
| expect(SilentErrorLib, 'returns silent-error').to.equal(SilentError); |
There was a problem hiding this comment.
@stefanpenner This prints a deprecation when testing, but I'm completely forgetting how I can capture that in a unit test to validate.
rwjblue
added a commit
that referenced
this pull request
Jul 8, 2015
[BUGFIX] Fixes #4397 add silentError with deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4397
I can try and write a quick test for this as well if desired.