Nasty broccoli fix to make it more stable on windows #493
Conversation
|
@MajorBreakfast can we lock to a known tag, I don't want to introduce instability as you iterate |
|
@stefanpenner I really don't want to iterate on that. It's a stupid fix which Jo could merge as an interim solution into broccoli. It doesn't address the actual problem, it just makes it disappear a bit. |
|
lets still tag it to a version |
|
I am STRONGLY in favor of not changing this. If the problem is in the Watcher, just use our own watcher. It is completely pluggable. We are instantiating manually anyways (in the |
|
@rjackson That's a good idea :) |
|
I have already localized all of the instantiation of the Watcher in https://github.com/stefanpenner/ember-cli/blob/master/lib/utilities/build-watcher.js. Make that file instantiate a custom class, and done. No need to fork or maintain a long running divergent branches or anything. |
|
can you add a changelog entry, and a quick inline comment so source readers know the context and the origin of the solution |
| @@ -28,3 +31,52 @@ module.exports = function(options) { | |||
|
|
|||
| return watcher; | |||
| }; | |||
|
|
|||
| function Watcher(builder) { | |||
There was a problem hiding this comment.
can we put the watcher in its own file?
There was a problem hiding this comment.
We have to rethink the file structure in another PR. utilities/ seems the wrong folder for these files in the first place.
Nasty broccoli fix to make it more stable on windows
@ebryn requested that I upload this super hacky broccoli fix for windows
How it works:
Instead of crashing on various file errors, it uses the async rimraf to remove the problematic file and rebuilds again (and again) until the build succeeds.