Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Node v5 to Appveyor #5033

Merged
merged 1 commit into from
Nov 21, 2015
Merged

Added Node v5 to Appveyor #5033

merged 1 commit into from
Nov 21, 2015

Conversation

patocallaghan
Copy link
Contributor

No description provided.

@stefanpenner
Copy link
Contributor

👍

@stefanpenner
Copy link
Contributor

kicking appveyor, ironically v5 was the only one that passed :P

@rwjblue
Copy link
Member

rwjblue commented Nov 3, 2015

LOL

@stefanpenner
Copy link
Contributor

lots of windows things fixed, rebase and this might be good. If not we will have to deep dive.

@patocallaghan
Copy link
Contributor Author

Just rebased

@patocallaghan
Copy link
Contributor Author

Failed again for Windows. Most errors seem to be of the below variety.

 3) Acceptance: blueprint smoke tests "before each" hook for "generating an http-proxy installs packages to package.json":
     Error: EPERM: operation not permitted, unlink 'C:\projects\ember-cli\tmp\concat_with_maps-output_path-XjvyZ6jS.tmp\addons.js'
      at Error (native)

@kellyselden
Copy link
Member

Probably a temporary failure, found in #5055.

@stefanpenner
Copy link
Contributor

@kellyselden likely

@stefanpenner
Copy link
Contributor

rebase please, potentially clear up windows issue

@patocallaghan
Copy link
Contributor Author

Rebased and pushed..

@stefanpenner
Copy link
Contributor

Thx

@chadhietala
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Nov 21, 2015

📌 Commit 1292be9 has been approved by chadhietala

@homu
Copy link
Contributor

homu commented Nov 21, 2015

⌛ Testing commit 1292be9 with merge 9fafb34...

homu added a commit that referenced this pull request Nov 21, 2015
@homu
Auto merge of #5033 - patocallaghan:appveyor_node_v5, r=chadhietala
9fafb34 
Added Node v5 to Appveyor
@homu
Copy link
Contributor

homu commented Nov 21, 2015

☀️ Test successful - status

@homu homu merged commit 1292be9 into ember-cli:master Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@patocallaghan @stefanpenner @rwjblue @kellyselden @chadhietala @homu @joostdevries