Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picking changelog from stable #5149

Merged
merged 1 commit into from
Nov 22, 2015
Merged

Conversation

kellyselden
Copy link
Member

No description provided.

kellyselden pushed a commit that referenced this pull request Nov 22, 2015
cherry-picking changelog from stable
@kellyselden kellyselden merged commit 370f3da into master Nov 22, 2015
@kellyselden kellyselden deleted the kellyselden-patch-1 branch November 22, 2015 16:25
@stefanpenner
Copy link
Contributor

so, I dont think we should continue cherry-picking the change-logs. The 2 branches will diverge, there may end up being overlap but that will continue to change.

@rwjblue
Copy link
Member

rwjblue commented Nov 22, 2015

@stefanpenner - When people come to look at what has changed they look at the repo, by default that means they land on the master branch. Having master include all changelogs for cut versions is pretty common (we do this for Ember as well). IMO, all stable versions should be included in the CHANGELOG.md on master.

@stefanpenner
Copy link
Contributor

non-linear changelogs do not make sense, at the point of divergence please put a link to the appropriate changelog.

@stefanpenner
Copy link
Contributor

in this case, the link would be: https://github.com/ember-cli/ember-cli/blob/stable-1-13/CHANGELOG.md

something like: 'forked off stable-1-13, to click here its change-log'

@rwjblue
Copy link
Member

rwjblue commented Nov 23, 2015

From users perspective the changes are linear, and the majority of changes listed for 1.13.13 are also in master.

If we don't want to maintain the file in the repo, that seems fine (we can use https://github.com/ember-cli/ember-cli/releases/ links), but to have the file and it be wrong and incomplete makes no sense.

@stefanpenner
Copy link
Contributor

and the majority of changes

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants