[ENHANCEMENT] Use absolute import paths for tests -> app imports #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue r+ |
|
@homu r+ |
|
📌 Commit 4853733 has been approved by |
homu
added a commit
that referenced
this pull request
Jan 26, 2016
…rwjblue [ENHANCEMENT] Use absolute import paths for tests -> app imports As per @stefanpenner 's [comment](#5194 (comment)). I used `dasherizedModulePrefix` instead of `dasherizedPackageName` to preserve existing behavior - app namespace for apps, and dummy for addons. If this looks good I can update other blueprints - `helper-test` - `initializer-test` - `instance-initializer-test` - `mixin-test`
|
☀️ Test successful - status |
|
I will be travelling this week. I'll try to update the rest of the blueprints sometime early next week. Thanks. |
homu
added a commit
that referenced
this pull request
Feb 16, 2016
[ENHANCEMENT] Use absolute imports in tests Continuation of #5203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @stefanpenner 's comment.
I used
dasherizedModulePrefixinstead ofdasherizedPackageNameto preserve existing behavior - app namespace for apps, and dummy for addons.If this looks good I can update other blueprints
helper-testinitializer-testinstance-initializer-testmixin-test