Add ability to lint templates. #5561
Conversation
rwjblue
force-pushed
the
lint-templates
branch
2 times, most recently
from
6a1b0b3
to
a6455f7
Compare
rwjblue
changed the title
rwjblue
force-pushed
the
lint-templates
branch
4 times, most recently
from
a0bbf9b
to
4945655
Compare
|
Updated to add tests and remove |
|
Node 0.12 and 5 passed in AppVeyor, the failures there seem random (I've restarted 3 times and a different node version fails each time 😞). |
|
@stefanpenner - any objections? |
|
Chatted in slack about this with Stef, we need to do some benchmarks to make sure we don't introduce a perf regression... |
|
Tests of master vs these changes in the ember-cli/stress-app (after updating it in ember-cli/stress-app#13) are here. Basic gist:
|
|
@rwjblue 👍 looks like nothing surprising snuck in re: perf, 🚢 |
|
Ya, but definitely better to be safe than sorry... |
|
I'm doing a few more small checks locally with my addon (ember-cli-template-lint) to make sure all is well. Will land it as soon as everything there checks out... |
|
@homu r+ |
|
📌 Commit 17619b8 has been approved by |
|
⚡ Test exempted - status |
Add ability to lint templates. Allows tooling like ember-cli-template-lint to work.
Allows tooling like ember-cli-template-lint to work.