Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX canary] Remove test-loader from tests/index blueprint #5962

Merged
merged 1 commit into from Jun 10, 2016

Conversation

josemarluedke
Copy link
Contributor

@josemarluedke josemarluedke commented Jun 9, 2016

Since the test-loader was moved to NPM (#5885), calling test-loader.js from index is not necessary anymore.

@Turbo87
Copy link
Member

Turbo87 commented Jun 9, 2016

@trentmwillis r?

@trentmwillis
Copy link
Member

👍 test-loader should now get put into test-support so this seems good

@rwjblue
Copy link
Member

rwjblue commented Jun 9, 2016

We should likely do what we do for testem.js and have an empty file present for folks if they don't update their index.html. What do y'all think?

@trentmwillis
Copy link
Member

How about logging/throwing an error in that file so they know to update?

@stefanpenner
Copy link
Contributor

How about logging/throwing an error in that file so they know to update?

sounds good, ideally verbose warning/log. Eventually a throw?

@Turbo87 Turbo87 added this to the v2.7.0 milestone Jun 10, 2016
@Turbo87
Copy link
Member

Turbo87 commented Jun 10, 2016

the warning/log thing seems to be something that can be layered on top of this PR so I'm gonna go ahead and merge this.

since the testloader stuff is included in v2.7.0-beta.1 I'll cherry pick this down to the beta branch.

@homu r+

@homu
Copy link
Contributor

homu commented Jun 10, 2016

📌 Commit 4687fe3 has been approved by Turbo87

homu added a commit that referenced this pull request Jun 10, 2016
[BUGFIX canary] Remove test-loader from tests/index blueprint

Since the test-loader was moved to NPM (#5885), calling test-loader.js from index is not necessary anymore.
@homu
Copy link
Contributor

homu commented Jun 10, 2016

⌛ Testing commit 4687fe3 with merge 8a738a4...

@homu
Copy link
Contributor

homu commented Jun 10, 2016

☀️ Test successful - status

@homu homu merged commit 4687fe3 into ember-cli:master Jun 10, 2016
@stefanpenner
Copy link
Contributor

stefanpenner commented Jun 10, 2016

Hey guys, I'm having issues with test loader not being found.

@rwwagner90 can yo open a new issue (feel free to link back to this one) and if possible include a reproduction. That way we have something very actionable to work with.

@RobbieTheWagner
Copy link
Contributor

@stefanpenner done. Sorry about that. Deleted my noise from this PR and opened an issue.

@josemarluedke josemarluedke deleted the fix-test-index branch June 10, 2016 18:46
@stefanpenner
Copy link
Contributor

@rwwagner90 not a problem, we often lose track of issues posted in other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants