New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX canary] Remove test-loader from tests/index blueprint #5962
Conversation
👍 test-loader should now get put into test-support so this seems good |
We should likely do what we do for |
How about logging/throwing an error in that file so they know to update? |
sounds good, ideally verbose warning/log. Eventually a throw? |
the warning/log thing seems to be something that can be layered on top of this PR so I'm gonna go ahead and merge this. since the testloader stuff is included in v2.7.0-beta.1 I'll cherry pick this down to the @homu r+ |
📌 Commit 4687fe3 has been approved by |
[BUGFIX canary] Remove test-loader from tests/index blueprint Since the test-loader was moved to NPM (#5885), calling test-loader.js from index is not necessary anymore.
☀️ Test successful - status |
@rwwagner90 can yo open a new issue (feel free to link back to this one) and if possible include a reproduction. That way we have something very actionable to work with. |
@stefanpenner done. Sorry about that. Deleted my noise from this PR and opened an issue. |
@rwwagner90 not a problem, we often lose track of issues posted in other issues |
Since the test-loader was moved to NPM (#5885), calling test-loader.js from index is not necessary anymore.