Make app/addon readmes consistent #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build "change directory" instruction dynamically from project name - Update addon readme to match app readme language - Update ember-try command from `testall` to `each`
| * `npm install` | ||
| * `bower install` | ||
|
|
||
| ## Running | ||
|
|
||
| * `ember serve` | ||
| * Visit your app at http://localhost:4200. | ||
| * Visit your app at [http://localhost:4200](http://localhost:4200). |
There was a problem hiding this comment.
can we use <http://localhost:4200> here instead?
There was a problem hiding this comment.
I don't have a strong preference, I just copied how it's written in the app README
|
@homu r+ |
|
📌 Commit 8eb5bf9 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jul 8, 2016
Make app/addon readmes consistent - Build "change directory" instruction dynamically from project name - Update addon readme to match app readme language - Update ember-try command from `testall` to `each` /cc @rwjblue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testalltoeach/cc @rwjblue