Makes sure dependecies are loaded on demand #6072
Conversation
|
LGTM assuming all tests pass. Has the tradeoff of making it a bit less clear which dependencies are pulled into any particular "module." |
|
@homu r+ |
|
📌 Commit a9042f3 has been approved by |
Makes sure dependecies are loaded on demand results: https://gist.github.com/twokul/54542ed6783e20bbfd2f62bd9dfb89c7 before: ``` Total require(): 1375 Total time: 1.1s ``` after: ``` Total require(): 995 Total time: 832ms ``` depends on #6071 related to #6009
|
☀️ Test successful - status |
|
@twokul could I get you to use branches in a personal fork for PRs instead of branches in this repo? all the PR branches will get cloned too when someone forks this repo which looks a bit unclean and also makes Travis run the tests twice. @stefanpenner is an exception here because of the repo redirection rules that apply as long as he doesn't fork this repo again. |
|
@twokul - What command were you running for the benchmark times? I see in the gist that you include the output, but not the command you were executing. I'm guessing it was |
|
@twokul If you're doing a release with the event emitter, go ahead. |
results: https://gist.github.com/twokul/54542ed6783e20bbfd2f62bd9dfb89c7
before:
after:
depends on #6071
related to #6009