in-repo-addon: sort additions to ember-addon/paths #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this actually has consequences on the order in which addons run because of how we walk things. Namely, you could avoid all of As a result this could be considered a breaking change. Since this is the default behavior for full addons I believe it's worthwhile to be consistent at risk of surprising a few people using in-repo-addons. I suspect that the people using in-repo-addons will be comfortable specifying their DAG map and therefore consider the risk of this to be low enough that I'm going to land it. @homu r+ |
|
📌 Commit 47171ab has been approved by |
homu
added a commit
that referenced
this pull request
Sep 3, 2016
in-repo-addon: sort additions to ember-addon/paths We should probably alphabetize additions to `ember-addon/paths` like we do to `dependencies` [here](https://github.com/ember-cli/ember-cli/blob/79a4b40a1e7c0c9cb356fc2bcf3f0348a0191eb3/blueprints/addon/index.js#L46). For consistency, and also deterministic is always better for git diffs.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably alphabetize additions to
ember-addon/pathslike we do todependencieshere. For consistency, and also deterministic is always better for git diffs.