Prepares Ember CLI for new version of ember-welcome-page

[locks]

• Update ember-welcome-page dependency
• Re-introduce application.hbs template to include the new
  welcome-page component
• Release new ember-welcome-page version

[nathanhammond]

@ember-cli/core Thoughts on having Ember CLI run the default blueprint of any addon present after ember new or ember addon? This would avoid us having to hardcode what amount to blueprint-level changes into our app/addon blueprints.

I'm hesitant to enshrine what feel like blueprint related tasks into our blueprints. If y'all feel like that's a good feature I'll build it today (so that welcome-page may adopt it).

[Turbo87]

@nathanhammond 💯 👍 (see #6269)

[kellyselden]

Sounds good to me. ember init will probably want this feature too.

[nathanhammond]

I'm less sure about ember init as it's intended to be run in projects that are already set up.

[locks]

I'm less sure about ember init as it's intended to be run in projects that are already set up.

We should have this as a different thing 🤔

[kellyselden]

I'm less sure about ember init as it's intended to be run in projects that are already set up.

What about the scenario, you're doing an ember-cli upgrade via ember init. The default blueprint for package.json updated ember-cli-eslint from ^1.0.0 to ^2.0.0. There was a big default blueprint change in ember-cli-eslint that you need to run.

Isn't that the same problem as with new and addon?

[nathanhammond]

@kellyselden You make a good point. But unfortunately that implies that default blueprints must be idempotent/safe to rerun which is not something that we require at this time since they're only ever invoked once. This is a larger problem than I was thinking and I no longer want to block this PR on that effort.

[kellyselden]

Good point as well, I wasn't thinking of the blowing away of previous custom changes to blueprint. Carry on, no changes to ember init.

[nathanhammond]

Hokay, so, @locks, this is not blocked by CLI people's opinions. Just tests passing once the new version is released.

[nathanhammond]

@homu r+

[homu]

📌 Commit 58b7431 has been approved by nathanhammond

[nathanhammond]

@locks Thank you for your tireless efforts on this!

[homu]

⌛ Testing commit 58b7431 with merge cf97908...

[homu]

☀️ Test successful - status