Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Fastboot #28

Closed
bttf opened this issue May 7, 2016 · 9 comments
Closed

Not compatible with Fastboot #28

bttf opened this issue May 7, 2016 · 9 comments

Comments

@bttf
Copy link

bttf commented May 7, 2016

ember-cli-fastboot v0.6.2
ember-cli 2.6.0-beta.2

Newly created app is rendered as blank after running

ember fastboot --serve-assets

and accessing localhost:3000.

Console errors are about assets not being available (css/js files).

@stefanpenner
Copy link
Contributor

cc @tomdale, @acorncom

@acorncom
Copy link
Member

acorncom commented May 9, 2016

Given the fact that we're hijacking Express with this add-on (by taking over completely if our criteria are met), it would make sense that it's not working exactly right ... My preference might be to completely disable this add-on if run through Fastboot, but we would then not be serving things identically to what folks see without Fastboot.

@tomdale I wonder about just by-passing Fastboot completely in this add-on (if Fastboot is detected). Otherwise, we'll have to feed the results we're generating here back into Fastboot somehow ... Thoughts?

@locks
Copy link
Collaborator

locks commented May 9, 2016

As I see it, it would make sense for the welcome page to not be seen from FastBoot, as FastBoot shows what a "production" user would see. Conceptually it would make sense for FastBoot to provide its own welcome-page, possibly with instructions more specific to FastBoot.

@acorncom
Copy link
Member

acorncom commented May 9, 2016

It might be worth considering doing Fastboot-specific instructions here if we're going to use the same template / design to save on duplication. But if it'd be better to have different branding, etc than an entirely different page / add-on seems to make more sense ...

@acorncom
Copy link
Member

acorncom commented May 9, 2016

@bttf Do you get errors if you have an application.hbs file or any routes defined? Or does this only occur if you're starting a brand-new app up from scratch and haven't yet setup an app?

@jasonmit
Copy link

I believe this was resolved by the changes in 2.0.0. I'll validate that and report back.

@jasonmit
Copy link

Update, yup all fixed.

Unrelated but noticed this while setting up a demo against ^2.0.0, ember-welcome-page should include a blueprint which adds {{welcome-page}} into application.hbs. Want me to PR that?

@locks
Copy link
Collaborator

locks commented Oct 26, 2016

@jasonmit appreciated, but the blueprint actually needs to be generated with the app, see ember-cli/ember-cli#6378 :)

@locks locks closed this as completed Dec 9, 2016
@pavolatzonky
Copy link

pavolatzonky commented Nov 29, 2021

For anyone seeing this stacktrace in their fastboot starter fastboot app, welcome page component is missing in the prod build, don't waste much time with it 🙈 :

 TypeError: Cannot destructure property 'manager' of 'e' as it is null.
    at u.resolvedComponent (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2464:28)
    at /Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2359:5
    at ie (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2359:30)
    at l (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2350:1)
    at /Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2325:6
    at _.compile (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2260:173)
    at te (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2350:44)
    at /Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2346:30
    at Z.compile (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2347:23)
    at Object.evaluate (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2826:224)
    at Object.evaluate (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2633:13)
    at It.evaluateSyscall (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2934:61)
    at It.evaluateInner (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2928:138)
    at It.evaluateOuter (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2928:59)
    at Wt.next (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2989:26)
    at Wt._execute (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2988:25)
    at Wt.execute (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2987:298)
    at Qt.sync (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2991:86)
    at _r.render (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:566:546)
    at /Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:592:31
    at Nt (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:2924:5)
    at Pr._renderRoots (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:591:34)
    at Pr._renderRootsTransaction (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:596:10)
    at Pr._renderRoot (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:590:50)
    at Pr._appendDefinition (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:585:6)
    at Pr.appendOutletView (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:583:6)
    at invokeWithOnError (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:3333:206)
    at h.flush (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:3325:74)
    at p.flush (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:3338:207)
    at B._end (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:3395:9)
    at B._boundAutorunEnd (/Users/puwel/Development/xamoom/client-prototype/dist/assets/vendor-cebbad065d28def16d70c7d49317aaf4.js:3347:605)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants