-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with Fastboot #28
Comments
Given the fact that we're hijacking Express with this add-on (by taking over completely if our criteria are met), it would make sense that it's not working exactly right ... My preference might be to completely disable this add-on if run through Fastboot, but we would then not be serving things identically to what folks see without Fastboot. @tomdale I wonder about just by-passing Fastboot completely in this add-on (if Fastboot is detected). Otherwise, we'll have to feed the results we're generating here back into Fastboot somehow ... Thoughts? |
As I see it, it would make sense for the welcome page to not be seen from FastBoot, as FastBoot shows what a "production" user would see. Conceptually it would make sense for FastBoot to provide its own welcome-page, possibly with instructions more specific to FastBoot. |
It might be worth considering doing Fastboot-specific instructions here if we're going to use the same template / design to save on duplication. But if it'd be better to have different branding, etc than an entirely different page / add-on seems to make more sense ... |
@bttf Do you get errors if you have an |
I believe this was resolved by the changes in 2.0.0. I'll validate that and report back. |
Update, yup all fixed. Unrelated but noticed this while setting up a demo against ^2.0.0, ember-welcome-page should include a blueprint which adds |
@jasonmit appreciated, but the blueprint actually needs to be generated with the app, see ember-cli/ember-cli#6378 :) |
For anyone seeing this stacktrace in their fastboot starter fastboot app, welcome page component is missing in the prod build, don't waste much time with it 🙈 :
|
ember-cli-fastboot v0.6.2
ember-cli 2.6.0-beta.2
Newly created app is rendered as blank after running
and accessing
localhost:3000
.Console errors are about assets not being available (css/js files).
The text was updated successfully, but these errors were encountered: