New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Watch vendor by default. #6436

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
5 participants
@nathanhammond
Contributor

nathanhammond commented Nov 16, 2016

Closes #6431.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Nov 16, 2016

Contributor

:shipit:

We should strongly consider a more formal API (for future work), by which we can ask the watcher is watching something or not.

Contributor

stefanpenner commented Nov 16, 2016

:shipit:

We should strongly consider a more formal API (for future work), by which we can ask the watcher is watching something or not.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 16, 2016

Contributor

👍

Contributor

rwjblue commented Nov 16, 2016

👍

@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond
Contributor

nathanhammond commented Nov 16, 2016

@homu r+

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Nov 16, 2016

Contributor

📌 Commit 2726bf1 has been approved by nathanhammond

Contributor

homu commented Nov 16, 2016

📌 Commit 2726bf1 has been approved by nathanhammond

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Nov 16, 2016

Contributor

⚡️ Test exempted - status

Contributor

homu commented Nov 16, 2016

⚡️ Test exempted - status

@homu homu merged commit 2726bf1 into ember-cli:master Nov 16, 2016

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.882%
Details
homu Test exempted
Details

homu added a commit that referenced this pull request Nov 16, 2016

Auto merge of #6436 - nathanhammond:watch-vendor, r=nathanhammond
[BUGFIX] Watch vendor by default.

Closes #6431.

@nathanhammond nathanhammond deleted the nathanhammond:watch-vendor branch Nov 16, 2016

@Turbo87 Turbo87 added this to the v2.11.0 milestone Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment